fix: fixed a crash when specifying the HTML pre tag

vivliostyle · Apr 8, 2021 · 3fbbb82 · 3fbbb82
1 parent 30b23bc
commit 3fbbb82
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/plugins/figure.ts b/src/plugins/figure.ts
@@ -61,8 +61,8 @@ export const hast = () => (tree: Node) => {
   visit<HastNode>(tree, 'element', (node, index, parent) => {
     // handle captioned code block
     const maybeCode = node.children?.[0] as HastNode | undefined;
-    if (is(node, 'pre') && maybeCode?.properties.title) {
-      const maybeTitle = maybeCode?.properties?.title;
+    if (is(node, 'pre') && maybeCode?.properties?.title) {
+      const maybeTitle = maybeCode.properties.title;
       delete maybeCode.properties.title;
       (parent as Parent).children[index] = h(
         'figure',

diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -89,3 +89,16 @@ it('empty replace', () => {
   ).toBe(`<p>[icon1][Notice]</p>
 <p>[person][Nod nod]</p>`);
 });
+
+it('<pre>', () => {
+  const actual = lib.stringify(`<pre>\n*    *    *\n   *    *    *\n</pre>`, {
+    partial: true,
+    disableFormatHtml: true,
+  });
+  // In CommonMark parsing, a line break is inserted immediately after `<pre>`
+  // In this test, line breaks are intentionally removed according to the behavior of VFM.
+  const expected = `<pre>*    *    *
+   *    *    *
+</pre>`;
+  expect(actual).toBe(expected);
+});