Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

i18n: title tag and headings in capability map are in english in french version #56

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

dofeldsc
Copy link
Contributor

I added the multi-language terms and support for a part of the capability map
JIRA Ticket

but not just for fr_CA, i did it for every language in der VIVO-language Repository.

for description see PR in VIVO Repo

@@ -906,3 +906,5 @@ create_and_link_type_webpage=Webpage
claim_publications_by=Claim publications by
claim_publications_by_doi=DOI
claim_publications_by_pmid=PubMed ID

term_capitalized = Begriff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing group_capitalized defined in anywhere??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group_capitalized already exists in Vitro-languages (for example https://github.com/vivo-project/Vitro-languages/blob/sprint-i18n/de_DE/webapp/src/main/webapp/i18n/all_de_DE.properties).
Do you want me to add that extra one for the Capability Map?

Copy link
Member

@awoods awoods Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was not seeing it.
As a separate note, I wonder why "group" is not actually capitalized in:
https://github.com/vivo-project/Vitro-languages/blob/sprint-i18n/de_DE/webapp/src/main/webapp/i18n/all_de_DE.properties#L877

Anyways, this should be good as-is... pending some testing on my side.

@dofeldsc dofeldsc requested a review from awoods June 25, 2020 11:28
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

@@ -580,6 +580,8 @@ vis_caching_process = Was beinhaltet der Vorgang zur Zwischenspeicherung?
vis_tools_note_two = Zu diesem Zweck haben wir eine Zwischenspeicherungslösung entwickelt, die durch die Speicherung des RDF-Modells Informationen über die Hierarchie der Organisationen speichert -- d. h. welche Publikationen welchen Organisationen zugerechnet werden.
vis_tools_note_three = Zurzeit speichern wir diese Modelle im Hauptspeicherbereich zwischen. Der Zwischenspeicher wird (nur einmal) bei der ersten Benutzeranfrage nach einem Neustart des Servers aufgebaut. Daher wird bis zum nächsten Neustart das gleiche Modell bedient. Das bedeutet, dass die Daten in den Modellen veralten können, je nachdem, wann das Modell zum letzten Mal erstellt wurde. Das funktioniert fürs Erste gut. In kommenden Releases werden wir diese Lösung dahingehend verbessern, dass Modelle auf Festplatte gespeichert und regelmäßig aktualisiert werden.
vis_tools_note_four = Die Modelle werden bei jedem Neustart des Servers aktualisiert. Da dies auf der Produktionsinstanz allgemein unpraktisch ist, können AdministratorInnen stattdessen den “Zwischenspeicher aktualisieren”-Link oben verwenden, um ohne einen Neustart eine Aktualisierung durchzuführen.
capability_map=Capability Map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in German, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you go down some lines the h2 tag says "Capability Map" to and the rest is in german. There is a pending ticket in the german fork where they discuss a good translation. So i think it is fine for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh they resolved it, i will change it now. it will be "Forschungsnetz"

@awoods awoods merged commit 08e6a32 into vivo-project:sprint-i18n Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants