Removed dateTimeWithPrecision_fr_CA.ftl and added properties required to work with improved dateTimeWithPrecision.ftl #89
Conversation
… to work with improved dateTimeWithPrecision.ftl
The german translation is good with the exception of |
@dofeldsc While searching Urhzeit to correct it, I found that it is the term used elsewhere... Should I leave it as is? |
In my opinion, the other two should rather be "Zeitintervall", "Uhrzeit" means time in german..."Zeit" also means time. But for intervals it should be "Zeitintervall". Correct me if i am wrong my german speaking friends :) |
No correction. Date-Time-Intervall shouls be Zeitraum or Zeitintervall. I would prefer Zeitraum. |
Gentlemen, I had my fair share of deutsche grammar arguments in another life, and proved many time how clueless I was. I'll let you confer and decide what to do here. |
We had a brief discussion and were able to agree on the following |
@awoods An agreement was reached on German translation. |
Since the template file is part of core Vitro, shouldn't these i18n strings be in the Vitro-languages repo instead of this one? |
@gneissone Makes sense. |
Agreed. Aligning Vitro-language updates with Vitro, and VIVO-language updates with VIVO is the pattern to follow. Among other things, it allows for the continued use of Vitro as a standalone project. |
Will do. |
Since it was not a full revert to the original files, and since I'm not mastering squash, I just went with a new commit. Sorry for the mess. |
Fix to : https://jira.lyrasis.org/browse/VIVO-1877
Related PR :
What it does
Adds the properties required to make dateTimeWithPrecision.ftl core file universal (vivo-project/Vitro#203).
Also, removed unnecessary dateTimeWithPrecision_fr_CA.ftl file
How to test it
Browse to Events > [some event] > Overview > date/time interval > add and check labels in the form.
Fix has been tested with fr_CA, en_CA, en_US, pt_BR, de_DE and es contexts.