i18n: Widget control buttons for capability map are in english in french version #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dofeldsc
changed the title
|
my branch name had the wrong Ticket number, i am closing this one and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.
JIRA Issue
Second required PR
What does this pull request do?
The PR will add multi-language support for a part of the capability map and the title of the site.
What's new?
This PR will add two variables for the multi-language support in the needed js-file and use them. If they are not provided by the language-templates the previous terms ("Term" and "Group") will be used.
How should this be tested?
You go to the capability map, search for something (with sample data for example "Rhetoric") and then click the "informations" Button. The Group and the Term should be multi-lingual. Just like the title of the page.
Additional Notes:
Note: Ignore the name of the branch, i accidentally used the number of my other ticket. 1847 would be the right one