-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example.runtime.properties #222
Conversation
Supersedes: #214 |
Looks great. My only question is whether it would be more consistent to comment out the (empty) SMTP/replyTo properties rather than leaving them uncommented with empty values. |
If I recall correctly VIVO complains if the properties are missing. Let's see if my memory is correct... Edit - must have been a fever dream, seems to work fine. |
@awoods Just occurred to me we should update this value, too
es_GO doesn't exist for VIVO anymore, correct? I imagine the logic for using the non-standard locale is still in the source, but the language files have been renamed to just 'es' if I recall correctly. |
Since that will require additional testing, let's keep the scope of this set of PRs constrained... and revisit |
@gneissone : since both you and I have fingerprints on this PR, it would be nice if someone else performed the "squash/merge". |
See #194 for details
Resolves: https://jira.lyrasis.org/browse/VIVO-1930