Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example.runtime.properties #222

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Conversation

awoods
Copy link
Member

@awoods awoods commented Feb 11, 2021

@awoods
Copy link
Member Author

awoods commented Feb 11, 2021

Supersedes: #214

@brianjlowe
Copy link
Member

Looks great. My only question is whether it would be more consistent to comment out the (empty) SMTP/replyTo properties rather than leaving them uncommented with empty values.

@gneissone
Copy link
Member

gneissone commented Feb 11, 2021

Looks great. My only question is whether it would be more consistent to comment out the (empty) SMTP/replyTo properties rather than leaving them uncommented with empty values.

If I recall correctly VIVO complains if the properties are missing. Let's see if my memory is correct...

Edit - must have been a fever dream, seems to work fine.

brianjlowe
brianjlowe previously approved these changes Feb 11, 2021
@gneissone
Copy link
Member

@awoods Just occurred to me we should update this value, too

# languages.selectableLocales = en_US, es_GO

es_GO doesn't exist for VIVO anymore, correct? I imagine the logic for using the non-standard locale is still in the source, but the language files have been renamed to just 'es' if I recall correctly.

@awoods
Copy link
Member Author

awoods commented Feb 11, 2021

@awoods Just occurred to me we should update this value, too

# languages.selectableLocales = en_US, es_GO

es_GO doesn't exist for VIVO anymore, correct? I imagine the logic for using the non-standard locale is still in the source, but the language files have been renamed to just 'es' if I recall correctly.

Since that will require additional testing, let's keep the scope of this set of PRs constrained... and revisit es_GO as a follow-on activity.

@awoods
Copy link
Member Author

awoods commented Feb 12, 2021

@gneissone : since both you and I have fingerprints on this PR, it would be nice if someone else performed the "squash/merge".

@brianjlowe brianjlowe merged commit 5f6cabc into vivo-project:main Feb 12, 2021
@awoods awoods deleted the vivo-1930 branch February 12, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants