Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-language-specific Vitro annotations to VIVO tbox firsttime d… #225

Merged
merged 2 commits into from Mar 30, 2021

Conversation

brianjlowe
Copy link
Member

@brianjlowe brianjlowe commented Feb 22, 2021

…irectory.

JIRA Issue:

What does this pull request do?

Moves non-language-specific vitro annotations from VIVO-languages into VIVO's home/resources/rdf/tbox/firsttime.

What's new?

Adds file home/resources/rdf/tbox/firsttime/vitroAnnotations.n3 with non-language-tagged content.

How should this be tested?

Should be tested in conjunction with vivo-project/VIVO-languages#95 .
After applying both pull requests, there will be no functional changes.

The following SPARQL query should show that vitro:fullPropertyNameAnnot values now have en-US tags:

SELECT ?o WHERE {
?x vitro:fullPropertyNameAnnot ?o
} ORDER BY ?o

All other vitro annotation properties should remain unchanged, but will be managed in different files. You can test this by modifying a displayLimitAnnot value in VIVO/home/src/main/resources/rdf/tbox/firsttime , redeploying and restarting. A query like the following will show your new value:

SELECT ?x ?o WHERE {
?x vitro:displayLimitAnnot ?o
} ORDER BY ?x ?o

Interested parties

@VIVO-project/vivo-committers

@roflinn roflinn self-requested a review March 2, 2021 16:11
@delsborg delsborg self-assigned this Mar 2, 2021
Copy link
Collaborator

@litvinovg litvinovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@roflinn roflinn merged commit 2fa7cce into vivo-project:rel-1.12.0-alpha Mar 30, 2021
ghost pushed a commit that referenced this pull request Feb 23, 2023
#225)

* Move non-language-specific Vitro annotations to VIVO tbox firsttime directory.

* Update tbox/firsttime readme to document difference between vitroAnnotations.n3 and initialTBoxAnnotations.n3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants