Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not offer UMLS vocabulary in interface if umls.properties is absent. #241

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

brianjlowe
Copy link
Member

@brianjlowe brianjlowe commented Jun 2, 2021

https://jira.lyrasis.org/browse/VIVO-1992:

Does not include UMLS in the list of vocabulary sources if umls.properties is not present on the resource path.

How should this be tested?

  1. On a person profile, click Rolodex icon next to "research areas".
    Click "Add Concept".
    List should include AGROVOC, GEMET, LCSH but not UMLS.
  2. Leave Tomcat running and add a file called "umls.properties" to WEB-INF/classes/ inside the webapp in Tomcat.
  3. Refresh the add concept page. UMLS should now be offered.

Interested parties

@VIVO-project/vivo-committers

@brianjlowe brianjlowe requested a review from gneissone June 2, 2021 12:16
@brianjlowe brianjlowe changed the title Do not offer UMLS vocabulary in interface is umls.properties is absent. Do not offer UMLS vocabulary in interface if umls.properties is absent. Jun 2, 2021
Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works (UMLS service works, as well)

@gneissone gneissone merged commit 603e7f6 into vivo-project:rel-1.12.0-RC Jun 9, 2021
@brianjlowe brianjlowe deleted the issue/VIVO-1992 branch June 15, 2021 13:28
ghost pushed a commit that referenced this pull request Feb 23, 2023
…t. (#241)

* Replace hardcoded en locale with current locale in lang attributes

* Do not offer UMLS vocabulary service in interface if umls.properties is absent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants