Multiple fixes for VIVO pages #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
force-pushed
the
i18n_departments_research_areas_pages
branch
from
2cdb023
to
ac304b8
Compare
|
Everything is fine. |
chenejac
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Fixes for pages
/affiliatedDepartments
/affiliatedResearchAreas
/deptResearchAreas
/deptGrants
How should this be tested?
Add sample data, view pages listed above, click individual links,
verify that links are working even if individual is not from default namespace for that instance.
On example of concept page should be associated department only in one language.
Applied on https://vivo.tib.eu/vivo113rc
Interested parties
@VIVO-project/vivo-committers