Use fallbacks for concept labels with en-US, en, and without language… #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tag in visualization caches
litvinovg
force-pushed
the
capability_map_fix
branch
from
370efdf
to
4362061
Compare
brianjlowe
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Works. Unrelated to this PR, but potentially of interest for anyone else who wants to test this: After adding my concept with language tag-less label, I had to restart VIVO before it appeared in the capability map interface. "Rebuild visualization cache" didn't make a difference, and indeed claimed that no cached data yet existed.
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2023
… tag in visualization caches (#3808) Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
If concept doesn't have label with language tag it can't be used in capability map.
This is a fix for capability map regression from i18n sprint.
What's new?
Use fallbacks for concept labels with en-US, en, and without language tag in visualization caches.
How should this be tested?
Interested parties
@chenejac @bkampe