Change PropertyKey class name and namespace #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
@brianjlowe well done. Please check one my comment in associated Vitro PR.
ivanmrsulja
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue 3862:
What does this pull request do?
Changes PropertyKey class to UILabel to align with naming already in use, and changes /core/properties/ part of namespace to /vitro/ui-label/ to clearly differentiate this application ontology from the VIVO core ontology.
How should this be tested?
A description of what steps someone could take to:
Interested parties
@VIVO-project/vivo-committers