Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape html values #3868

Merged
merged 3 commits into from
May 9, 2023
Merged

Escape html values #3868

merged 3 commits into from
May 9, 2023

Conversation

litvinovg
Copy link
Collaborator

@litvinovg litvinovg commented Apr 28, 2023 •
edited
Loading

VIVO GitHub issue
Vitro PR

What does this pull request do?

Fixes some freemarker templates to avoid invalid html.

How should this be tested?

  1. Create individual with Label Create data property with value </div>"</div>
  2. Add primary email address to a profile with a text </div>"</div>
  3. Verify that profile page is not broken
  4. Try to delete email address, verify that delete page is not broken.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

@litvinovg litvinovg mentioned this pull request Apr 28, 2023
Merged
chenejac
chenejac approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks, looks great and work as expected.

@chenejac chenejac linked an issue May 1, 2023 that may be closed by this pull request
Some freemarker templates don't have escaped values #3869
Closed
@chenejac chenejac requested a review from milospp May 8, 2023 14:37
@chenejac chenejac removed the request for review from brianjlowe May 9, 2023 11:04
@chenejac chenejac merged commit c7dcc09 into vivo-project:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenejac chenejac chenejac approved these changes

@milospp milospp milospp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some freemarker templates don't have escaped values
3 participants
@litvinovg @chenejac @milospp