Fixing Wilma responsive theme update #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty control panel buttons
Closed
chenejac
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
@milospp I have tested the new wilma theme:
- If I am using some standard device dimensions (PC, laptop), it looks it works the same as before improving responsibility of wilma, meaning I didn't find any issue which was introduced
- If I am using mobile device dimensions, it looks perfect if I am using landscape orientation, while there are some small issues with portrait orientation:
- when I am logged in, the main menu options for logged in user (my account, and log out) are behind the VIVO headline
- some green buttons not completely visible at screen (scrolling is needed): http://localhost:8080/vivo/propertyEdit?uri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FOBI_0000417#
The previously stated issues are not blocking for this PR from my point of view, because wilma theme makes VIVO fully functional at mobile devices. However, if you can fix those issues, it would be great.
milospp
added a commit
to milospp/VIVO
that referenced
this pull request
Apr 9, 2024
…roperty control panel buttons (vivo-project#3932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Solves: #3933
This pull request updates the frontend components affected by the integration of Bootstrap into the Wilma theme in PR #3909.
How should this be tested?
Compare pages in the old Wilma theme with the updated version.
The theme should remain mostly similar but with added responsiveness.
After update:
