Sanitized search-related freemarker variables #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
@litvinovg looks nice.
I have tested all themes and it works as described with the exception of the nemo theme. For the nemo theme after selection of a filter, the initial query is not anymore in the url path, and therefore results are not as expected, only filter is taken into account, but not search query. I think this issue is not introduced by this PR (therefore I will approve this PR), but please check whether you can fix that.
P.S. I didn't check to use html tags in the n3 configuration of the extended search
gneissone
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
Vitro PR
What does this pull request do?
Sanitized Freemarker variables in search templates.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers