[VIVO-1605] Update to latest Error Prone plugin and configuration to support JDK 11 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(duplicate of comment on vivo-project/Vitro#88) It seems inappropriate to use a SNAPSHOT version of a dependency. We could issue a VIVO release, and then a new SNAPSHOT of the dependency could be issued, potentially breaking our release. Am I understanding this correctly? |
|
Graham - Could you please update this to the release version of the plugin? It was just released a few hours ago. https://github.com/google/error-prone/releases/tag/v2.3.2 |
|
@roflinn OK - had some problems with the Error Prone documentation being slightly out for Java 8, but this is all working now. |
gneissone
approved these changes
Oct 24, 2018
roflinn
approved these changes
Oct 24, 2018
chenejac
pushed a commit
to chenejac/VIVO
that referenced
this pull request
Sep 29, 2022
… to work with improved dateTimeWithPrecision.ftl (vivo-project#89) * Removed dateTimeWithPrecision_fr_CA.ftl and added properties required to work with improved dateTimeWithPrecision.ftl * Moving Vitro related properties in Vitro-languages Fix to : https://jira.lyrasis.org/browse/VIVO-1877 Related PR : - vivo-project/Vitro#203 - vivo-project/Vitro-languages#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO-1605:
What does this pull request do?
Updates the pom.xml to use the latest version of Google's Error Prone plugin and configuration, so that the build works with recently released JDKs
What's new?
Nothing
How should this be tested?
Do a full "mvn clean install" - the compilation should complete normally.
Should be tested with multiple JDK versions - should work for everything from JDK 8 through to the recently released JDK 11
Interested parties
@VIVO-project/vivo-committers