Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 8] Dynamic REST API routes #22

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2022

Vitro-angular GitHub issue: #8

What does this pull request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.

Example:

  • Changes x feature to such that y
  • Added x
  • Removed y

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the pull request does what is intended.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository?
  • Could this change impact execution of existing code?
  • Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR doesn't introduce circular dependencies
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the Vitro-angular License.

@ghost ghost linked an issue Jun 17, 2022 that may be closed by this pull request
William Welling and others added 6 commits June 17, 2022 14:19
* update package lock file

* refactor reducer to core store

* remove default schematics collection

* add api base url to environment

* rest docs feature store

* add state tests

* fix effects test

* fix prod base url

* fix devtools

* add prettierrc and format

* update app component spec to run lifecycle hooks

* refactor rest docs to rest api

* test fail fetch api in effects

* formatting

* Updating of a resource request should use previous id (uri), not new one

Co-authored-by: William Welling <8352733+wwelling@users.noreply.github.com>
Co-authored-by: chenejac <chenejac@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dynamic routing from dynamic REST API
1 participant