-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jena version to 3.16.0 #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually fixes VIVO-1943. With 50K insert batches, the master branch immediately throws StackOverflowExceptions. With this pull request applied, works fine.
@brianjlowe How are you doing the batch inserts? Have you used the VIVO Update api for 50k inserts? I had some problem with SDB direct when I was using v3 Jena libraries. It went away when I updated to 3.16.0 for ReCiter-Connect. |
@sarbajitdutta My testing was exclusively using the VIVO SPARQL Update API. This was a series of INSERT DATA { GRAPH <...> { ... } } requests to the API where each request contained 50000 serialized triples. |
@brianjlowe @awoods I tried the fix but for big publications it fails with this message. Also, I did not set the maxPostSize in tomcat server.xml for 8080 port. By default it fails and it vivo.all.log it says this
|
* Upgrade Jena version to 3.16.0 (vivo-project#196) Related to: https://jira.lyrasis.org/browse/VIVO-1943 * remove example-settings.xml * update home directory untar non-destructive * checksum digest to retain modified files * compare checksum from digest with existing file * overwrite files that have not changed * add command to manually generate checksum digest * simplify parsing checksum digest using pattern Co-authored-by: Andrew Woods <awoods@lyrasis.org> Co-authored-by: Andrew Woods <awoods@duraspace.org>
* Upgrade Jena version to 3.16.0 (vivo-project#196) Related to: https://jira.lyrasis.org/browse/VIVO-1943 * remove example-settings.xml * update home directory untar non-destructive * checksum digest to retain modified files * compare checksum from digest with existing file * overwrite files that have not changed * add command to manually generate checksum digest * simplify parsing checksum digest using pattern * do not overwrite file if same as already exists Co-authored-by: Andrew Woods <awoods@lyrasis.org> Co-authored-by: Andrew Woods <awoods@duraspace.org>
* Create vivo/home on application start-up - Add logic for untarring vivo-home Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Require runtime.properties and applicationSetup.n3 be in 'config/' dir Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Support loading config files with or without 'default' prefix * Prioritize without the prefix Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Add leading slash to location of vivo-home.tar resource path * This allows for deployment in both Tomcat and Jetty Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Ensure VIVO_HOME is populated whether it is empty or not Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Require common properties to be in JNDI Properties include: - vitro/home - vitro/appName - vitro/rootUserAddress - vitro/defaultNamespace Related to: https://jira.lyrasis.org/browse/VIVO-1443 * VIVO-1443: non destructive vivo home untarring (#2) * Upgrade Jena version to 3.16.0 (#196) Related to: https://jira.lyrasis.org/browse/VIVO-1943 * remove example-settings.xml * update home directory untar non-destructive * checksum digest to retain modified files * compare checksum from digest with existing file * overwrite files that have not changed * add command to manually generate checksum digest * simplify parsing checksum digest using pattern Co-authored-by: Andrew Woods <awoods@lyrasis.org> Co-authored-by: Andrew Woods <awoods@duraspace.org> * not overwrite existing file if same as tar entry (#3) * Upgrade Jena version to 3.16.0 (#196) Related to: https://jira.lyrasis.org/browse/VIVO-1943 * remove example-settings.xml * update home directory untar non-destructive * checksum digest to retain modified files * compare checksum from digest with existing file * overwrite files that have not changed * add command to manually generate checksum digest * simplify parsing checksum digest using pattern * do not overwrite file if same as already exists Co-authored-by: Andrew Woods <awoods@lyrasis.org> Co-authored-by: Andrew Woods <awoods@duraspace.org> * Update log messages for clarity Co-authored-by: Andrew Woods <awoods@duraspace.org> Co-authored-by: William Welling <wwelling@library.tamu.edu> Co-authored-by: Gross, Benjamin <benjamin.gross@clarivate.com>
Related to: https://jira.lyrasis.org/browse/VIVO-1943
What does this pull request do?
Upgrades Jena from 3.11.0 to 3.16.0
What's new?
No functional change
How should this be tested?
A successful build indicates success
Additional Notes:
Based on the comment in the jena-users, I do not expect this upgrade will fix the issue in VIVO-1943.
However, the upgrade should generally be useful. I am happy to follow-up with another commit that adds the patch mentioned in the ticket regarding the use of
Syntax.syntaxARQ
.Interested parties
@VIVO-project/vivo-committers