Added individual-property-group-tabs_fr_CA.ftl to allow proper French capitalization #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accomplished this already without the additional freemarker template. |
|
Ok, same bug in several tickets. Sigh. Your fix is much more elegant than mine. I'll close this PR. |
|
Yeah, I was very confused by the subtasks as they all had the same details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution for https://jira.lyrasis.org/browse/VIVO-1853
Related PR : vivo-project/VIVO#205
What it does
It would be nice to be able to specify a proper capitalization for any language without having to create a different freemarker file, but it seems impossible at the moment. For the time being, I added a version of the individual-property-group-tabs_fr_CA.ftl.
How to test it
In the fr_CA context and Wilma theme, go to Recherche, select any document, and check the capitalization of tab titles. It should like this : "Infos supplémentaires sur le document"