Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nextBinding() method in FIlteredResultSet. #215

Merged
1 commit merged into from Apr 21, 2021
Merged

Implement nextBinding() method in FIlteredResultSet. #215

1 commit merged into from Apr 21, 2021

Conversation

brianjlowe
Copy link
Member

JIRA Issue:

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

Implements FilteredResultSet's nextBinding() method so that exceptions are not thrown during certain iterations through FilteredResultSets.

How should this be tested?

  • Before applying this pull request, create or navigate to the profile page of a person with vCard first and last names. Note that the QR code fails to appear under the profile picture and that the following appears in vivo.all.log:
    ERROR [IndividualResponseBuilder] Data retrieval for individual lead to error java.lang.UnsupportedOperationException: Can we ignore this? at edu.cornell.mannlib.vitro.webapp.rdfservice.filter.FilteredResultSet.nextBinding(FilteredResultSet.java:56)
    ....
  • Apply pull request
  • Navigate to same individual
  • Observe that QR code renders and error does not appear in logs.

Interested parties

@VIVO-project/vivo-committers

litvinovg
litvinovg approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@litvinovg litvinovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@brianjlowe
Copy link
Member Author

A committer can go ahead and merge, as this is a one-review type bugfix.

@ghost ghost merged commit 3984203 into vivo-project:rel-1.12.0-alpha Apr 21, 2021
@chenejac chenejac mentioned this pull request Oct 10, 2021
Closed
ghost pushed a commit that referenced this pull request Feb 23, 2023
@brianjlowe @wwelling
Implement nextBinding() method in FIlteredResultSet. (#215)
e543a7c
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litvinovg litvinovg litvinovg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brianjlowe @litvinovg