Add usePreciseSubqueries property to example.runtime.properties. Hav… #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RDFServiceTDB report a preference for precise optionals as does SDB.
This was referenced Mar 29, 2021
gneissone
reviewed
Mar 29, 2021
| @@ -93,6 +93,10 @@ public boolean changeSetUpdate(ChangeSet changeSet) | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean preferPreciseOptionals() { | |||
| return true; | |||
There was a problem hiding this comment.
@brianjlowe Does this change the default for TDB? In my (limited) testing using the precise subqueries improved performance with TDB, though as I understood it that was unexpected.
There was a problem hiding this comment.
That's right; this changes the default for TDB. The suggestion on the last call was that we should optimistically switch the TDB default, based on the limited results you and I had, and switch back if more extensive testing of the release candidate suggested otherwise.
There was a problem hiding this comment.
@brianjlowe Cool, thanks for confirming.
gneissone
approved these changes
Mar 29, 2021
litvinovg
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e RDFServiceTDB report a preference for precise optionals as does SDB.
JIRA Issue:
Companion VIVO PR: vivo-project/VIVO#233
https://wiki.lyrasis.org/display/VIVO/2021-03-23+-+VIVO+Development+IG
What does this pull request do?
Has TDB also report a preference for precise optionals (as SDB already does) so that precise-subquery patterns in list views will be included. Updates example.runtime.properties to show users how to set this behavior explicitly.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers