Use unique key in account activation link and reset password link #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved comment about old behaviour.
…ot_pending on key mismatch.
litvinovg
changed the title
brianjlowe
approved these changes
Jun 3, 2021
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Use unique key for email activation and password reset * Renamed old variable from hash to key * Check for null before setting email key for backward compatibility. Removed comment about old behaviour. * Send password_change_invalid_key message instead of password_change_not_pending on key mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Removes limit of 8 characters on passwordLinkExpiresHash and use unique key for account activation and password reset links.
Additional Notes:
Use in combination with PR vivo-project/Vitro-languages#47
How should this be tested?
With SMTP server configured in runtime.properties, create a new user with a valid email address. Confirm that the link sent in the email contains an activation code longer than 8 characters, and that the clicking the link successfully leads to the password setting page.
Try changing emailKey to verify that modified key doesn't lead to password setting page, instead message that link invalid will appear.
Reset user password. Confirm that the link sent in the email contains an activation code longer than 8 characters and that the clicking the link successfully leads to the password setting page.
Try changing emailKey to verify that modified key doesn't lead to password setting page, instead message that link invalid will appear.
Interested parties
@VIVO-project/vivo-committers