Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIVO-1989] URL-encode vCard-related resource URIs appended to edit links #235

Merged
merged 1 commit into from Jun 2, 2021

Conversation

brianjlowe
Copy link
Member

@brianjlowe brianjlowe commented Jun 1, 2021

https://jira.lyrasis.org/browse/VIVO-1989:

See Vitro-languages companion PR (vivo-project/Vitro-languages#48)

How should this be tested?

To reproduce bug:

  1. Install vivo to a context other than root, e.g. localhost:8080/vivo/
  2. Enter a person's preferred title / email / phone number / address or find an existing person with one or more of these.
  3. Edit the existing value. Erase the existing value and submit an empty field.
  4. You will be redirected out of the context: /editRequestDispatch?

To test fix, repeat the above steps. You should remain in the context and see a validation error prompting you to enter a value.

Interested parties

@VIVO-project/vivo-committers

Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed issue. Deployed with fix, issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants