[3696] Timestamped filename for named graph output #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
approved these changes
May 8, 2022
chenejac
approved these changes
May 11, 2022
There was a problem hiding this comment.
Works as expected and described. @gneissone thanks for the contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: resolves vivo-project/VIVO#3696
What does this pull request do?
Specifies a filename for named graph exports
What's new?
Specifies a filename for named graph exports composed of the last part of the named graph URI, plus the current datetime (on the server).
Example old filename: ingest.ttl
Example new filename: vitro-kb-2-2022-05-06-102044.ttl
How should this be tested?
Export various graphs using the 'Ingest tools' export function
Site Admin > Ingest Tools > Manage Jena Models > 'output model'
Confirm the file downloads correctly and has the appropriate filename.
Additional Notes:
This worked fine for me on both Chrome and Safari on macOs. Would be useful to test on a Windows machine using Edge.
Interested parties
@hauschke @vivo-project/vivo-committers