Workaround for creating integer literals #314
Conversation
There was a problem hiding this comment.
I could reproduce issue 3728. Applying this workaround led to the expected behaviour without throwing an exception.
There was a problem hiding this comment.
@litvinovg it works and I approve it. However, please check one my comment whether there is any sense in what is written.
|
|
||
|
|
||
| private static String replaceIntegerWithInt(String predicate) { | ||
| if( predicate.equals("http://www.w3.org/2001/XMLSchema#integer")) { |
There was a problem hiding this comment.
Can you define constants for http://www.w3.org/2001/XMLSchema#integer and http://www.w3.org/2001/XMLSchema#int? It might be also useful somewhere else. Also, I am not sure we need method here, maybe ternary operator can be used instead (langOrDatatype.equals(XML_INTEGER_TYPE))?XML_INT_TYPE:langOrDatatype.
There was a problem hiding this comment.
I didn't create constants as I think that this code is deprecated and should be removed after we replace n3editing with dynamic API. It is a separate method for the same reasons: to emphasize that it is a temporary fix and make it easy to remove it in future. Also ternary operators harder to read and less practical for debugging.
VIVO GitHub issue
What does this pull request do?
Fixes issue related to creating integer literals in web interface by substituting integer data type with int for purpose of creating hash. It is required as for now integer literals are stored as int.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers