Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ i18n sprint ] VIVO-3748 Remove "Other" special case from ChildVClassesWithParent #328

Merged
merged 1 commit into from Nov 15, 2022

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Sep 8, 2022

VIVO GitHub issue
Companion VIVO PR
Companion VIVO-languages PR

What does this pull request do?

Removed "Other" special case from ChildVClassesWithParent, instead provide names of parent and children.

Interested parties

@VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I am thinking should we base this PR on i18n-redesign branch.

@litvinovg litvinovg changed the base branch from main to i18n-redesign October 21, 2022 09:59
@chenejac chenejac requested review from brianjlowe and gneissone and removed request for brianjlowe October 25, 2022 08:40
@litvinovg litvinovg changed the title VIVO-3748 Remove "Other" special case from ChildVClassesWithParent [ i18n sprint ] VIVO-3748 Remove "Other" special case from ChildVClassesWithParent Nov 4, 2022
@chenejac chenejac merged commit 57d9328 into vivo-project:i18n-redesign Nov 15, 2022
ghost pushed a commit that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants