Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynapi] Actions permission check extension #343

Closed
wants to merge 45 commits into from
Closed

[Dynapi] Actions permission check extension #343

wants to merge 45 commits into from

Conversation

litvinovg
Copy link
Contributor

A follow up to this PR

What does this pull request do?

Extends permission checks for dynamic api actions

What's new?

  • Added UserAccessWhitelist to check permission by user email
  • Add publicAccess property setter to allow public access to Action
  • Added tests to test:
  • Only root allowed if permission access not configured
  • In case public access is set to true, then anyone can access action
  • Access allowed when user is in whitelisted group
  • If user email is allowed then user is allowed to access action

How should this be tested?

Run tests

Interested parties

@VIVO-project/vivo-committers

litvinovg and others added 30 commits August 26, 2022 16:25
@litvinovg
Renamed SparqlQuery component to SparqlSelectQuery
813aad9
@litvinovg
added SparqlConstructQuery component
fb71feb
@litvinovg
added simple sparql query integration tests.
7f230d7
@litvinovg
Instead of throwing error on empty sparql request provide default values
8f83a06
@litvinovg
basic implementation of DynapiJsonObject
7ed9a4c
@litvinovg
tests improvements
442a743
@litvinovg
refact: renamed DynapiJsonObject to JsonContainer
85d3d03
@litvinovg
Report Generator component start
d716046
@litvinovg
improvements for Report Generator
1caffa5
@litvinovg
json type added, sparql select produce json, test added
3ecc545
@litvinovg
ReportGenerator (supports xslx and docx)
3c2450e 
added some test cases TODO: check template format and configure report format
@litvinovg
removed unused imports
c4d84a8
@litvinovg
added ontology ReportGenerator class and properties
d3284c4
@litvinovg
Added integration tests for ReportGenerator. Extended usage of intern…
3e1e612 
…al paramters with initialization by default value and overriding setting in Parameter
@litvinovg
Added language tag filtering in SPARQL Queries
d87992e
@litvinovg
Sparql select language filtering test added
7c8881a 
Sparql construct language filtering test added
@litvinovg
I18n regression fix (vivo-project#289)
28b2738 
* fix: get back language filtering for sparql construct query

* feat: LanguageFilteringRDFService sparqlConstructQuery tests added
@litvinovg
Parsing accept-language header in converter
621aad3
@litvinovg
Cleanup, fixed formatting
16eb53d
@litvinovg
fix: missed character
881a831
@litvinovg
fix n3 syntax mistake
d310556
@litvinovg
improved content type detection
5f2d386
@litvinovg
Avoid dereferencing internal components
835ccfa
@litvinovg
User permissions check
b6f214c
@litvinovg
remove unused imports
c755c5b
@litvinovg
removed unsafe method and obsolete commented code
4ae53d9
@litvinovg
fix: sparql query validation check
19cd5e6
@litvinovg @chenejac
Update api/src/test/java/edu/cornell/mannlib/vitro/webapp/dynapi/Vali…
42ed273 
…datorsTest.java

Co-authored-by: Dragan Ivanovic <chenejac@uns.ac.rs>
@litvinovg @chenejac
Update api/src/test/java/edu/cornell/mannlib/vitro/webapp/dynapi/data…
e949bc7 
…/conversion/ParameterConverterTest.java

Co-authored-by: Dragan Ivanovic <chenejac@uns.ac.rs>
@litvinovg @chenejac
Update api/src/test/java/edu/cornell/mannlib/vitro/webapp/dynapi/Vali…
f25a2b8 
…datorsTest.java

Co-authored-by: Dragan Ivanovic <chenejac@uns.ac.rs>
@litvinovg
Copy link
Contributor Author

Superseded by #364

@litvinovg litvinovg closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@litvinovg