Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression fix for populated email, telehpone and website faux properties #360

Merged

Conversation

litvinovg
Copy link
Contributor

What does this pull request do?

Restores hidden populated email, telephone, fax, website properties in individual profiles

What's new?

Provided qualified by root faux property in FauxProperty class and FauxPropertyObjectWrapper to avoid filtering populated properties in GroupedPropertyList

How should this be tested?

  • Populate email, fax, telephone, website properties
  • Open individual profile
  • Verify that properties are present in profile

Interested parties

@brianjlowe @chenejac

Copy link
Member

@brianjlowe brianjlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed faux properties appear for an admin account and continue to appear when populated.

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works properly.

@chenejac chenejac merged commit 8b2e150 into vivo-project:i18n-redesign Feb 2, 2023
ghost pushed a commit that referenced this pull request Feb 23, 2023
…ertyWrapper (#360)

Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants