Fix for VIVO-3871 #393
Merged
Fix for VIVO-3871 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
@litvinovg the PR is fixing the issue described in the linked GitHub issue.
|
I've tested with the dataset in the linked issue. Adding mixed RDF results in the correct data and blank node structure in asserted-tbox plus the expected TBox inferences in inferred-tbox. However, when I do the reverse and remove mixed RDF using the same data, only the assertions are removed. For some reason, the TBox reasoner seems not to hear the removal and the orphaned inferred-tbox triples are getting stuck there. |
|
Bug above seems unrelated to PR. Also occurs in main; have opened new issue at vivo-project/VIVO#3884 |
brianjlowe
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Fallaback to search for BulkGraph mem in base graph if default graph unwrap failed.
How should this be tested?
Follow steps in the issue.
Interested parties
@brianjlowe