Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search download #4

Merged
merged 7 commits into from Jun 28, 2013
Merged

Feature/search download #4

merged 7 commits into from Jun 28, 2013

Conversation

drspeedo
Copy link
Contributor

New Potential Feature: Download Search Results

One of the items requested by faculty members at CU was to be able to search for things in VIVO and save their search results in CSV. These two commits add that functionality as a button beside the searched term on the results page and the user can download either xml or csv. Please comment with modifications to both code and usability. The icon is created to match icon's found in Vitro and VIVO and VIVO Cornell.

@drspeedo
Copy link
Contributor Author

Also, if this feature should be one of the activate-able features in the runtime, I'd appreciate any help in building that in to the feature.

@paulalbert1
Copy link

Nice idea, Stephen. I would love if you could put in parameters for count:

  • count = 100 --> first 100
  • count = 0 --> all

@drspeedo
Copy link
Contributor Author

Paul, this commit adds a button that opens a dialogue box to download either xml or csv. PageSearchResults use the default 25 per page and max 1000. If I added a box to the dialogue box with 500 in it and allowed someone to change it up to 1000 (or a slider or something else) would that meet your suggestion? PagedSearchResults allows you to modify the number (which is how I'm doing it) using the attribute hitsPerPage in the query string.

@paulalbert1
Copy link

As long as we are prevented by Solr from downloading any more records than 1,000 (I suppose for performance reasons), this sounds good.

I'm really pleased you're working on this. Search can be a lot more versatile.

@drspeedo
Copy link
Contributor Author

Thanks Paul! For Jim and everyone else, I'd like to test modifications to a pull request so I'm going to leave this open with these items to fix.

  • Add Slider/Text Box to change the hitsPerPage when downloading CSV or XML
  • Find out about URI unresolving issue (URI doesn't work, may have to add baseaddres/individual?uri=)
  • add moniker if possible (looking into individual at shortview in search-pagedResults)
  • add email if possible
  • add webpage if possible (for departments)
  • make sure that all querystring text is processed (all potential elements that could limit the search terms)

Jim, when I complete these items I'll look into revising this pull request OR closing it and starting a new one.

@j2blake
Copy link
Member

j2blake commented May 17, 2013

Thanks, Stephen. I'll wait until you tell me to review.

Jim

On 5/17/13 2:25 PM, "Stephen V. Williams" <notifications@github.commailto:notifications@github.com> wrote:

Thanks Paul! For Jim and everyone else, I'd like to test modifications to a pull request so I'm going to leave this open with these items to fix.

  • Add Slider/Text Box to change the hitsPerPage when downloading CSV or XML
  • Find out about URI unresolving issue (URI doesn't work, may have to add baseaddres/individual?uri=)
  • add moniker if possible (looking into individual at shortview in search-pagedResults)
  • add email if possible
  • add webpage if possible (for departments)
  • make sure that all querystring text is processed (all potential elements that could limit the search terms)

Jim, when I complete these items I'll look into revising this pull request OR closing it and starting a new one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-18078081.

…as Class when drilling down, added a slider that allows you to modify the maximum number of results returned and modified the csv template to include the sitename, query text, and date in its header
@drspeedo
Copy link
Contributor Author

Jim, This updated automatically (there is a text above the comment bar that mentions you can add more commits by pushing to feature/search-download and it worked). This is ready to go.

@drspeedo
Copy link
Contributor Author

I just added an additional commit that adds the number of records in class groups and classes to the searchTOC. This has been a request at CU Boulder for a while and I've seen some list traffic about it. The elements were already there I just exposed link.count in the template.

… changes for downloading results and adding counts to facets
@drspeedo
Copy link
Contributor Author

I merged develop back into this branch (since github reported it couldn't do an auto merge) and fixed an issue on the search pageResults where my changes were on lines that i18n changes.

@j2blake
Copy link
Member

j2blake commented Jun 13, 2013

Stephen;

I'm seeing two problems with the appearance of this change:
screen shot 2013-06-13 at 2 24 21 pm

I'm guessing that the "<<<<<< HEAD" text comes from line 26 in search-pagedResults.ftl
Any idea why the "Not the results you expected?" link is duplicated?

[[Please ignore the Spanish tab labels. That's a different problem altogether.]]

@tworrall
Copy link
Member

The span containing "Not the results you expected?" appears at both line 32 and 36 of search-pagedResults.ftl. The div element $('div.contentsBrowseGroup') also appears twice: lines 34 and 37.

The footer also expands beyond the right margin. I've seen this happen before and it's likely due to one of the css changes or inline styles. Setting the h2 element to float left is a possible culprit.

@drspeedo
Copy link
Contributor Author

That's all based on a bad Merge. I tried to pull develop into the branch
so it would merge properly when approved. Let me clean it up.

Stephen

On Fri, Jun 14, 2013 at 7:46 AM, tworrall notifications@github.com wrote:

The containing "Not the results you expected?" appears at both line 32 and
36 of search-pagedResults.ftl. The
element $('div.contentsBrowseGroup') also appears twice: lines 34 and 37.

The footer also expands beyond the right margin. I've seen this happen
before and it's likely due to one of the css changes or inline styles.
(Why, for example, was the
element set to float left?)


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-19457748
.

j2blake added a commit that referenced this pull request Jun 28, 2013
@j2blake j2blake merged commit 6641725 into develop Jun 28, 2013
@j2blake j2blake deleted the feature/search-download branch June 28, 2013 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants