Support self editor profile matching by using External Auth ID #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Mar 12, 2024
There was a problem hiding this comment.
@litvinovg well done.
I have reviewed the code and posted three comments.
In order to test this PR I had to apply patches from those PRs - #443 , #445
After application of those PRs it works as described.
.../main/java/edu/cornell/mannlib/vitro/webapp/auth/checks/SparqlSelectQueryResultsChecker.java
Outdated
Show resolved
Hide resolved
.../main/java/edu/cornell/mannlib/vitro/webapp/auth/checks/SparqlSelectQueryResultsChecker.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/PolicyHelper.java
Show resolved
Hide resolved
chenejac
previously approved these changes
Mar 14, 2024
|
Resolved merge conflict |
chenejac
approved these changes
Apr 4, 2024
brianjlowe
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
VIVO PR
What does this pull request do?
Fixes broken profile linking made by using External Auth ID.
What's new?
How should this be tested?
See VIVO PR
Interested parties
@VIVO-project/vivo-committers