New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search results sort fallback #456
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milospp, @litvinovg I can't reproduce the issue before application of this PR.
I have tried to turn off multilingual UI in the runtime.properties, but it is still sorting well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg thanks for the PR.
I have reproduced the issue before applying this fix. The PR is fixing the issue. However, there are five options if multilinguality of UI is turned off:
Sort by Relevance
Sort by Title Z-A
Sort by Title A-Z
Sort by Raw title Z-A
Sort by Raw title A-Z
The second and fourth options, as well as third and fifth options are working the same, but the last two options should be hidden (not to confuse the user).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg thanks for the improvements. It works nice, I have tested the feature with languageFilters and without. Please take a look into my comments.
home/src/main/resources/rdf/i18n/de_DE/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Raw" is not used that way in german, I would suggest to simply remove it.
home/src/main/resources/rdf/i18n/de_DE/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/display/firsttime/search_individuals_vitro.n3
Outdated
Show resolved
Hide resolved
…h_individuals_vitro.n3 Co-authored-by: Benjamin Kampe <benjamin@fehrmanns.net>
…h_individuals_vitro.n3 Co-authored-by: Benjamin Kampe <benjamin@fehrmanns.net>
…h_individuals_vitro.n3 Co-authored-by: Benjamin Kampe <benjamin@fehrmanns.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg this looks ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg Thanks for the fix, this is working for me.
VIVO GitHub issue
What does this pull request do?
Added sort fallback option to provide an option to sort on multiple fields.
What's new?
Added vitro-search:hasFallback object property to specify fallback sort options.
Defined raw name field and field sort options in search configuration.
Defined score field for default (relevance) sort option.
Used raw name sort options as fallback for language specific sort options.
Added Added vitro-search:display data property to control display of sort options.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers