Filter unavailable variable substitutions in Sparql query data getter. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
force-pushed
the
data-getter-fix
branch
from
ff9e8e6
to
1e92f83
Compare
chenejac
requested changes
Apr 5, 2024
There was a problem hiding this comment.
@litvinovg I can't reproduce the issue before application of this PR. Please describe in details steps for reproducing the issue.
|
chenejac
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
@litvinovg I reproduced the issue before this PR and can confirm this PR is fixing the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Fixes the issue by filtering variable substitutions not specified in sparql query text.
What's new?
Added test to check substitution filtering.
Improved error logging.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers