Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jquery and Jquery UI webjars #464

Merged
merged 3 commits into from
May 30, 2024

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Apr 24, 2024

What does this pull request do?

Added webjars with latest jquery and jquery ui versions
Added datatables dependency used by Map of Science
https://mvnrepository.com/artifact/org.mvnpm/datatables.net/2.0.5
Added jquery migrate dependency
https://mvnrepository.com/artifact/org.webjars.npm/jquery-migrate/3.4.1
All dependencies are licensed under the MIT license.

How should this be tested?

Build Vitro and VIVO

Interested parties

@gneissone

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Maven

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@chenejac chenejac requested a review from wwelling May 2, 2024 14:28
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment

@litvinovg thanks a lot for this PR.

Testing

I have run building of VIVO and webjars directory inside webapps/target directory has been created.

Code reviewing

I have posted one comment regarding group id for datatables.net artifact. I am also wondering whether we need all those dependencies extracted into webjars directory, or we can use existing js, and css directories?

webapp/pom.xml Show resolved Hide resolved
webapp/pom.xml Show resolved Hide resolved
webapp/pom.xml Show resolved Hide resolved
@hudajkhan
Copy link
Member

hudajkhan commented May 9, 2024 via email

@chenejac chenejac merged commit 10dccd6 into vivo-project:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants