VIVO-1437 Add pull request template #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
requested changes
Feb 5, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| **Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.** | ||
| * * * | ||
|
|
||
| **[JIRA Issue](https://jira.duraspace.org)**: (please link to issue) |
There was a problem hiding this comment.
Can we change this link to https://jira.duraspace.org/projects/VIVO
awoods
approved these changes
Feb 5, 2018
|
Thanks, @gneissone. This looks good to me. Given the non-controversial nature of this PR, I would be inclined to merge it with one more approval from a @vivo-project/vivo-committers . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.
JIRA Issue: https://jira.duraspace.org/browse/VIVO-1437
What does this pull request do?
Adds a pull request template. See https://github.com/blog/2111-issue-and-pull-request-templates for a little information on pull request templates.
What's new?
This adds a new .github directory and the template text file.
How should this be tested?
The pull request form should be auto-populated with this form once the pull request is accepted. Only affects functionality on github.com, not the application.
Additional Notes:
N/A
Interested parties
@awoods