[VIVO-1613] Fix menu ordering bug #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjlowe
approved these changes
Oct 22, 2018
brianjlowe
approved these changes
Oct 22, 2018
gneissone
approved these changes
Oct 24, 2018
This was referenced Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO-1613:
What does this pull request do?
Fixes problem of a blank menu ordering page
What's new?
None
How should this be tested?
Visit the menu ordering page in site admin - it should be populated, and allow you to re-order the entries
Additional Notes:
OK, here's the kicker.
The issue that this commit addresses was introduced in 2012(!), when the RDFService was being implemented, and it was never passed through to the ObjectPropertyStatementDAO.
This means that: for menu ordering to be working in prior releases, then something else must have changed to use this code path.
Interested parties
@VIVO-project/vivo-committers