Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Sample update with fr-CA translations #2

Closed
wants to merge 4 commits into from

Conversation

KitioFofack
Copy link

@KitioFofack KitioFofack commented Apr 30, 2018

This PR add few translations in french to the dataset.
These are useful to test the i18n on Capability Map

Copy link
Member

@hauschke hauschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the comments. I'd like to see an opinion by @mconlon17 on this, too.

obo:RO_0000052 <http://vivo.mydomain.edu/individual/n1736> ;
vivo:dateTimeInterval <http://vivo.mydomain.edu/individual/n6945> ;
vivo:roleContributesTo <http://vivo.mydomain.edu/individual/n6748> .

<http://vivo.mydomain.edu/individual/n5685>
a vivo:EditorRole ;
rdfs:label "Editor in Chief"@en-US ;
rdfs:label "Editeur en Chef"@fr-CA ;
obo:RO_0000052 <http://vivo.mydomain.edu/individual/n1736> ;
vivo:dateTimeInterval <http://vivo.mydomain.edu/individual/n2585> ;
vivo:roleContributesTo <http://vivo.mydomain.edu/individual/n6748> .

<http://vivo.mydomain.edu/individual/n6561>
a skos:Concept ;
rdfs:label "Electracy"@en-US ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The english label for http://vivo.mydomain.edu/individual/n6561 "Electracy" (https://en.wikipedia.org/wiki/Electracy), which shouldn't be translated to "Électricité".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was unable to translate that word in french that's why I wrote what google translate gave me. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to keep Electracy in French, too. Else I'm fine.

obo:ARG_2000028 <http://vivo.mydomain.edu/individual/n4712> ;
obo:RO_0000053 <http://vivo.mydomain.edu/individual/n2816> , <http://vivo.mydomain.edu/individual/n1515> ;
vivo:relatedBy <http://vivo.mydomain.edu/individual/n2543> , <http://vivo.mydomain.edu/individual/n6053> , <http://vivo.mydomain.edu/individual/n5058> .

<http://vivo.mydomain.edu/individual/n6748>
a bibo:Journal ;
rdfs:label "Journal of Political Rhetoric"@en-US ;
rdfs:label "Journal de Politique Rhétorique"@fr-CA ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's disputable if journal titles should be translated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point @hauschke !
From a technical perspective however, it does not make any difference if the string tagged as french is actually written in english or another language.

Base automatically changed from master to main January 20, 2021 17:27
@chenejac
Copy link
Contributor

Meanwhile sample-data repository has been restructured and internationalized. There is an i18n directory with sample-data for specific language including fr_CA. Therefore, this pull request is outdated and should be closed.

@chenejac chenejac closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants