Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Scroll State (2) #64

Merged
merged 24 commits into from
Sep 23, 2023
Merged

Save Scroll State (2) #64

merged 24 commits into from
Sep 23, 2023

Conversation

vixalien
Copy link
Owner

Supported pages

  • Home
  • Playlist
  • Album
  • Artist
  • Search Results
  • Library
  • Library Playlists
  • Library Albums
  • Library Artists
  • Library Subscriptions
  • Library Songs
  • History
  • Artist Albums
  • Channel
  • Channel Playlists
  • Explore
  • Charts
  • Moods and genres
  • Mood
  • New Releases

Checking if all pages work correctly

  • Home (!)
  • Playlist
  • Album
  • Artist
  • Search Results
  • Library (!)
  • Library Playlists (!)
  • Library Albums (!)
  • Library Artists (!)
  • Library Subscriptions (!)
  • Library Songs
  • History (!)
  • Artist Albums
  • Channel
  • Channel Playlists
  • Explore (!)
  • Charts
  • Moods and genres
  • Mood
  • New Releases

Items with (!) for some reason save the scroll state well, but won't restore it: they restore the state but then they immediately scroll to the top.

fix #49

@vixalien
Copy link
Owner Author

supersedes #50

@vixalien vixalien mentioned this pull request Sep 16, 2023
40 tasks
@vixalien
Copy link
Owner Author

I wonder if I might need to merge this ASAP, then create an issue that tracks all the pages that don't seem to respect scrolling position

@vixalien vixalien merged commit 14eebef into main Sep 23, 2023
2 checks passed
@vixalien vixalien deleted the scroll-state-2 branch September 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Remember scroll state while navigating
1 participant