Metainfo file validation failing

[rffontenelle]

Spotted with meson test

data/com.vixalien.sticky.appdata.xml: FAILED:
• attribute-invalid     : <screenshot> width (422) too small [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/note.png] minimum is 624px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/note.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/note.png]
• attribute-invalid     : <screenshot> width (422) too small [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/notes.png] minimum is 624px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/notes.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/vixalien/sticky/v0.1.1/data/resources/screenshots/notes.png]
• style-invalid         : <ul> cannot start a description [(null)]
• style-invalid         : Not enough <p> tags for a good description [0/1]
stderr:
Validation of files failed

[vixalien]

oh well.

I think most of the errors are because the image is too small and that the images have padding (i.e the space between the window and the image's borders)

I think we don't want to make the images larger, as usually sticky notes are meant to be small. The padding is also put there by GNOME's screenshot tool, which allows to show the drop shadow. Other GNOME app's screenshots also have the padding.

For the other errors, I'll make sure to fix them

[rffontenelle]

Then you might want appstream validation to be lax (validate -> validate-relax), so running meson test in CLI or adding run-tests: true to flatpak/flatpak-github-actions action doesn't fail.

sticky/data/meson.build

Line 41 in 74ebf8d

test('Validate appstream file', appstream_util, args: ['validate', appstream_file])

[rffontenelle]

Would you be interested in this kind of annotation of appstream-util output? This is possible adding a problem-matcher rule that matches appstream-util's output. So, instead of having to enter the log to view the error message, they are annotated in the Summary page of the workflow run.

[vixalien]

yes that would be great. I'll create a PR soon making validate -> validate-relax)

…

On Fri, 19 May 2023, 16:09 Rafael Fontenelle, ***@***.***> wrote: Would you be interested in this kind of annotation of appstream-util output? [image: Captura de tela de 2023-05-19 11-08-44] <https://user-images.githubusercontent.com/1571783/239554441-f122aff1-51c9-4d28-bb30-ffcbc39e7f96.png> — Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJB5FCJVYIETW5WEJ7JW7HLXG55KFANCNFSM6AAAAAAYFVUWPQ> . You are receiving this because you commented.Message ID: ***@***.***>

[vixalien]

should be fixed by #110