allow '$' to indicate last day-of-month #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2023
millert
requested changes
May 29, 2023
zhjwpku
reviewed
May 30, 2023
|
No.
p vixie
|
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
May 31, 2023
Paul and me had a discussion about adding the feature of last day of month, because there are things you must do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees You may see the PR here: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
May 31, 2023
Paul and me had a discussion about adding the feature of last day of month, because there are things you must do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees You may see the PR here: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
May 31, 2023
Paul and I had a discussion about adding the feature of last day of month, there are things you must do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees So this is a resonable feature, see the PR here: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
May 31, 2023
Paul and I had a discussion about adding the feature of last day of month, there are things you must do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees So might be a reasonable feature, backport from this PR: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
May 31, 2023
Paul and I had a discussion about adding the feature of last day of month, there are things you want do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees So this might be a reasonable feature, backport from this PR: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
In load_entry, for @daily or @midnight, we should set every bit for the dow bitstr_t, pull request 16 just set FIRST_DOW, which wrong; for @hourly, the set_element of dow is redundant since set_range set each bit of dow. I believe these are typos when replacing bit_set/bit_nset using set_element/set_range, I did't review it carefully, sorry for the inconvenient. Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
62a064f replaced the for loop of set_element with the newly added set_range, so the variable i is no longer needed. Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added a commit
to zhjwpku/pg_cron
that referenced
this pull request
Jun 5, 2023
Paul and I had a discussion about adding the feature of last day of month, there are things you want do on the last day of the month, like: - pay your rent, mortgage - visit your mother or parole officer - calculate paychecks for your empoyees So this might be a reasonable feature, the idea using '$' to indicate last day-of-month came from regex syntax, '$' is the end of a line. backport from this PR: vixie/cron#20 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Junwang Zhao zhjwpku@gmail.com