Combo box filtering does not work

[GammaSagittarii]

Hi, the combobox in demo in the widget gallery example does not filter the options list as I think is intended.
It looks like this:

After changing https://github.com/vizia/vizia/blob/main/crates/vizia_core/src/views/combobox.rs#L199
to self.filter_text.clone_from(text);
it works as expected.

[geom3trik]

Thank you for the detailed report and fix :)

[GammaSagittarii]

No problem, glad to be of help. The library seems to have a lot of potential. Thank you for open sourcing it! P.S. I thought that the line self.placeholder.clone_from(text); is not necessary as the filter is being set while the combo is being edited - which means that it is not showing the placeholder. If the option is changed it sets the placeholder on change so it gets updated anyway, and if option is not changed and editing is abandoned it reverts to the previously selected option and also sets the placeholder.

…

On Sat, Apr 6, 2024 at 6:37 PM Dr George Atkinson ***@***.***> wrote: Thank you for the detailed report and fix :) — Reply to this email directly, view it on GitHub <#467 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHVUGCTOLKRO7JVICQV7TB3Y4AQDFAVCNFSM6AAAAABF2O2MFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGEZTGNJQHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[geom3trik]

P.S. I thought that the line self.placeholder.clone_from(text); is not
necessary as the filter is being set while the combo is being edited -
which means that it is not showing the placeholder.
If the option is changed it sets the placeholder on change so it gets
updated anyway, and if option is not changed and editing is abandoned it
reverts to the previously selected option and also sets the placeholder.

Ah yes good spot. It seems that placeholder should have been filter_text all along. Will clean that up at some point.