Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus improvements #185

Merged
merged 6 commits into from Aug 1, 2022
Merged

Focus improvements #185

merged 6 commits into from Aug 1, 2022

Conversation

0HyperCube
Copy link
Contributor

  • Focus style updates displays immediately
  • The focus_order example always keeps your focus on the buttons
  • Add KEYBOARD_NAVIGATABLE ability to allow for focusable elements that are not in the tab order (the equivalent of tabindex="-1" in html)
  • Buttons get focused on click (this triggers the focus pseudo class which equivalent behaviour to html - html also has the :focus-visible pseudo class to only show the style when using keyboard navigation which we may also want)

Copy link
Collaborator

@geom3trik geom3trik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for your contribution. Just a couple of very minor changes and then this is good to be merged. I agree that a :focus-visible pseudo-selector should be added next, along with an outline property, which is on my todo list.

core/src/style/mod.rs Outdated Show resolved Hide resolved
core/src/context/mod.rs Outdated Show resolved Hide resolved
core/src/context/mod.rs Outdated Show resolved Hide resolved
@geom3trik
Copy link
Collaborator

Related to #55

@geom3trik geom3trik merged commit e444728 into vizia:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants