Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack OBJLoader to work with machinedrum/ocean-of-thought objs #2092

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

kschzt
Copy link
Contributor

@kschzt kschzt commented Feb 28, 2018

This is a bug that slipped in the last release. When decimating objects in Blender, they are left with l lines in the .obj that are out of place, making the loader attempt to put two kinds of geometries in the same object. This works around that bug by simply ignoring the l lines altogether, like the previous version of the loader did.

Copy link
Contributor

@gmarinov gmarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hotfix lgtm
left a todo for further investigation in #2093

@kschzt
Copy link
Contributor Author

kschzt commented Feb 28, 2018

Here is an OBJ in a ZIP that has this problem. Very possibly a problem in Blender. The l lines shouldn't be going into the same geometry as the v lines? dikart3.obj.zip

@kschzt kschzt merged commit 3515738 into develop Feb 28, 2018
@kschzt kschzt deleted the fix-oot branch February 28, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants