Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Vizzu, vizzu lib getter in player #60

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

dovicsin
Copy link
Contributor

No description provided.

@veghdev
Copy link
Member

veghdev commented Aug 30, 2023

It can be a bit misleading that there is now a this.vizzu and a this.Vizzu too.
The previous internally used this.vizzu did not have an explicit getter function, so I would rename it to something more descriptive and use this.vizzu to store the lib. What do you think @dovicsin ?

@dovicsin
Copy link
Contributor Author

@veghdev , I think the vizzuStoryInstance was the most descriptive name. What do you think?

@veghdev
Copy link
Member

veghdev commented Aug 30, 2023

@veghdev , I think the vizzuStoryInstance was the most descriptive name. What do you think?

nevermind, after some thinking, the current one is good, the class is uppercase, the instance is lowercase.

@dovicsin dovicsin merged commit 6c7189f into vizzuhq:main Aug 30, 2023
7 checks passed
@veghdev veghdev changed the title add vizu lib getter in player Added: Vizzu, vizzu lib getter in player Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants