Fix <this.x />

Would be nice to get it properly handled in eslint/typescript-eslint-parser#307 Fixes prettier#1877
vjeux · Jun 2, 2017 · 05a9e77 · 05a9e77
1 parent 7fd71fa
commit 05a9e77
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/src/printer.js b/src/printer.js
@@ -1507,12 +1507,9 @@ function genericPrintNoParens(path, options, print, args) {
       return concat(parts);
     case "JSXIdentifier":
       // Can be removed when this is fixed:
-      // https://github.com/eslint/typescript-eslint-parser/issues/257
-      if (n.object && n.property) {
-        return join(".", [
-          path.call(print, "object"),
-          path.call(print, "property")
-        ]);
+      // https://github.com/eslint/typescript-eslint-parser/issues/307
+      if (!n.name) {
+        return "this";
       }
       return "" + n.name;
     case "JSXNamespacedName":

diff --git a/tests/typescript_tsx/__snapshots__/jsfmt.spec.js.snap b/tests/typescript_tsx/__snapshots__/jsfmt.spec.js.snap
@@ -37,3 +37,10 @@ const MyCoolList = ({ things }) =>
 const MyCoolThing = ({ thingo }) => <li>{thingo}</li>;
 
 `;
+
+exports[`this.tsx 1`] = `
+<this.state.Component />;
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+<this.state.Component />;
+
+`;
diff --git a/tests/typescript_tsx/this.tsx b/tests/typescript_tsx/this.tsx
@@ -0,0 +1 @@
+<this.state.Component />;