Support postcss v8.0.0 #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjhenkes I can confirm this worked for me using your master branch inside package.json. It would be nice to have a temporary NPM release ( like postcss-rtl-fix ) of your fork cause I doubt this PR will be merged soon. |
|
@redaxmedia, I went ahead and published a temporary fork. I plan to use it until I can get my projects migrated over to rtlcss as it seems to be more actively maintained than this project. |
|
@mjhenkes Another fix was to add |
|
New release closes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded postcss-rtl to support postcss v8.0.0.
I followed this guide: https://evilmartians.com/chronicles/postcss-8-plugin-migration
The diff looks messier than it is, the plugin is largely unchanged besides what was recommended in the guide.
I did not look at optimizing the plugin, I think that is a task better left to those more familiar with this plugin.
I considered opening up the version to support both 7 and 8 but that didn't seem possible due to the changes for the v8.0.0 api and the fact that the postcss-import dependency only support version 8.
One wrinkle is that postcss removed the vendor api in version 8, but on inspection it was a simple string replace function and I directly added that to this plugin.
See: https://github.com/postcss/postcss/blob/7.0.35/lib/vendor.es6#L42 for the original post css implementation.
Closes #71