Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 1, Exercise 2: Retrying Failed Requests #10

Open
simon-wolf opened this issue Feb 15, 2019 · 2 comments
Open

Section 1, Exercise 2: Retrying Failed Requests #10

simon-wolf opened this issue Feb 15, 2019 · 2 comments

Comments

@simon-wolf
Copy link

simon-wolf commented Feb 15, 2019

The code in the ePub version contains a bug which is not in the PDF version with the root variable because it includes /posts.

In addition there is a related issue in the line:

const content = await getWithRetry(`${root}?id=${p.id}`, 3);

It should be:

const content = await getWithRetry(`${root}/post?id=${post.id}`, 3);
@simon-wolf simon-wolf changed the title Exercise 2: Retrying Failed Requests Section 1, Exercise 2: Retrying Failed Requests Feb 15, 2019
@vkarpov15
Copy link
Owner

Thanks for reporting, will check later today and get you a fixed epub. Just to confirm, you're referring to this example? https://imgur.com/a/98pJYC6

@simon-wolf
Copy link
Author

simon-wolf commented Feb 16, 2019

Thank you but there's no rush to get me a new ePub. I'm cross-checking it with the PDF version for now because it looks like some updates and edits didn't make it across. If it is easier, maybe wait until I've looked through the rest of the book before creating a new ePub.

The issue itself is in the code for Example 2 in the first section.

This is the ePub version:

ePub version.

This is the PDF version:

PDF version.

The root path in the ePub version is tied to posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants