Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform return for array response #14

Merged
merged 1 commit into from
Nov 13, 2018
Merged

fix: transform return for array response #14

merged 1 commit into from
Nov 13, 2018

Conversation

artemkobets
Copy link
Contributor

#12 introduced a bug in which attachVirtuals() was returning response after first for iteration for document arrays, which resulted in only first document getting populated.

@artemkobets artemkobets mentioned this pull request Nov 12, 2018
Closed
@nicolas-marien
Copy link
Contributor

😱 sorry about that...

vkarpov15
vkarpov15 approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@vkarpov15 vkarpov15 merged commit 4dcce07 into mongoosejs:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemkobets @nicolas-marien @vkarpov15