Fix: Replica Set options fixed and error gracefully handled #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush-uipath
commented
Nov 30, 2020
| @@ -118,7 +118,7 @@ function* run() { | |||
| if (commander.bind_ip_all) { | |||
| options.bind_ip_all = null; | |||
| } | |||
| return options; | |||
| return {options: options}; | |||
There was a problem hiding this comment.
@vkarpov15 Did you check this line? I think this fix is needed and didn't go as part of #48 or #50
The way options is passed to ReplSet constructor is not in the format the Constructor expects it. That what i have fixed here.
There was a problem hiding this comment.
Oh my bad, I see you have changed options to { options } . That addresses it. Thanks.
ayush-uipath
commented
Nov 30, 2020
| @@ -208,6 +208,7 @@ function startRS(rs) { | |||
| try { | |||
| yield rs.start(); | |||
| } catch (err) { | |||
| err = err[0]; | |||
There was a problem hiding this comment.
I agree this is addressed in #48 Not needed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I am requesting you to merge this PR. This addresses 2 issues:
options was not passed from the index file correctly into the ReplSet constructor. It needed to be an object with options key having a nested json with the actual options. I've addressed the same.
The startRS catch block had an error in itself. If err didn't contain message field, we were still doing err.message.includes, which was breaking saying TypeError: Cannot read property 'includes' of undefined . I've added graceful handling of the same.
Please review.
Thanks,
Ayush Jain