Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend jsx-jcs-no-undef to work with <With /> #19

Closed
martinmacko47 opened this issue May 21, 2017 · 5 comments
Closed

Extend jsx-jcs-no-undef to work with <With /> #19

martinmacko47 opened this issue May 21, 2017 · 5 comments

Comments

@martinmacko47
Copy link
Contributor

We have just added <With /> statement to jsx-control-statements. We need to extend jsx-jcs-no-undef rule to work with variables declared by the new statement. I'll create a PR for it.

Usage of the With statement:

    <For each="item" of={this.props.items}>
      <With value={computeValue(item)}>
        <Choose>
          <When condition={item.path}>
            <Link to={item.path}>{value}</Link>
          </When>
          <Otherwise>
            {value}
          </Otherwise>
        </Choose>
      </With>
    </For>
martinmacko47 added a commit to martinmacko47/eslint-plugin-jsx-control-statements that referenced this issue May 21, 2017
@martinmacko47
Copy link
Contributor Author

martinmacko47 commented Jun 13, 2017

@vkbansal Could somebody please review PR #19?

@vkbansal
Copy link
Owner

I've approved it. But the build is failing.

Also I'm looking for maintainers.

@martinmacko47
Copy link
Contributor Author

I'll try to fix CI errors. But they seem to be happening before the PR as well.

As for maintaining, I'm not sure I understand eslint-plugin-jsx-control-statements nor jsx-control-statements good enough to be able to maintain it.

@martinmacko47
Copy link
Contributor Author

@vkbansal I've fixed CI errors, but they were definitelly independent of with control statements changes. So I put the test fix into a separate commit.

If you are ok with the changes, please merge the change a release a new version of the package to npm. Thanks

vkbansal added a commit that referenced this issue Jun 13, 2017
@vkbansal
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants