Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Check that the menu should be visible when setting display properties #289

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

negasora
Copy link
Contributor

Fixes #252

@vkbansal vkbansal merged commit 44a6281 into vkbansal:master Aug 12, 2019
@kinke
Copy link

kinke commented Sep 10, 2019

This hack makes the menus not hide at all. Note that this change is equivalent to removing the else branch altogether, as it is only entered if !this.state.isVisible anyway.

kinke pushed a commit to Lean5/react-contextmenu that referenced this pull request Sep 10, 2019
kinke pushed a commit to Lean5/react-contextmenu that referenced this pull request Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu does not close when clicking outside in a project that sets state in raw DOM click handlers.
3 participants