Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically save before building project #610

Closed
dazappa opened this issue Jan 28, 2021 · 2 comments · Fixed by #616
Closed

Automatically save before building project #610

dazappa opened this issue Jan 28, 2021 · 2 comments · Fixed by #616
Assignees
Labels
enhancement Request: New feature or improvement
Projects

Comments

@dazappa
Copy link

dazappa commented Jan 28, 2021

If a document or the project itself has unsaved changes, the "Build Project" function in the "Build Novel Project" dialog will build the novel project with the latest saved changes, not the latest changes open in any editor.

Consider forcefully saving the editor / project when "Build Project" is clicked, before novelWriter performs its actual building functionality to ensure when "Build Project" is pressed it will always build the novel with the latest changes.

@dazappa dazappa added the enhancement Request: New feature or improvement label Jan 28, 2021
@vkbo
Copy link
Owner

vkbo commented Jan 28, 2021

The project data is read from the in-memory project dictionary, and the order of items in the tree widget are flushed before the build, so that part is fine. The text from documents are read from file though, and you're probably right that the latest content isn't saved first. It's an easy enough one-line fix to manually trigger the document auto-save function.

@vkbo vkbo self-assigned this Jan 28, 2021
@vkbo vkbo added this to the Release 1.1 RC 1 milestone Jan 28, 2021
@vkbo vkbo added this to To Do (Features) in Release 1.1 Jan 28, 2021
@vkbo vkbo linked a pull request Jan 28, 2021 that will close this issue
@vkbo vkbo moved this from To Do (Features) to In Progress in Release 1.1 Jan 28, 2021
vkbo added a commit that referenced this issue Jan 28, 2021
@vkbo
Copy link
Owner

vkbo commented Jan 28, 2021

Added and merged into the release branch, which will be tagged for Version 1.1 RC 1 this weekend.

@vkbo vkbo closed this as completed Jan 28, 2021
Release 1.1 automation moved this from In Progress to Done Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement
Projects
No open projects
Release 1.1
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants